bootstrap: Split out a separate ./x test bootstrap-py step
#148459
Merged
+35
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When working on the Rust parts of bootstrap, it's unhelpful for `./x test bootstrap` to also run Python unit tests.
rustbot
added
A-testsuite
|
r? @clubby789 rustbot has assigned @clubby789. Use |
|
r? @Kobzol |
Kobzol
approved these changes
Nov 4, 2025
| let host = builder.config.host_target; | ||
| let build_compiler = builder.compiler(0, host); | ||
| fn should_run(run: ShouldRun<'_>) -> ShouldRun<'_> { | ||
| // Bootstrap tests might not be perfectly self-contained and can depend |
There was a problem hiding this comment.
I think the bootstrap Python tests should be fine locally, but they are IMO not very useful anyway, so let's just run them only on CI.
|
@bors r+ |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Nov 4, 2025
Rollup of 4 pull requests Successful merges: - #144529 (Add `#[rustc_pass_indirectly_in_non_rustic_abis]`) - #147017 (FCW for repr(C) enums whose discriminant values do not fit into a c_int or c_uint) - #148459 (bootstrap: Split out a separate `./x test bootstrap-py` step) - #148468 (add logging to `fudge_inference_if_ok`) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Nov 4, 2025
Rollup merge of #148459 - Zalathar:bootstrap-py, r=Kobzol bootstrap: Split out a separate `./x test bootstrap-py` step While testing changes to bootstrap, I was annoyed by the fact that `./x test bootstrap` spams a bunch of mysterious output to the console. That output turns out to come from `bootstrap_test.py`, which runs unit tests for the Python parts of bootstrap. Those tests are (presumably) useful, but they don't add value when working on the Rust parts of bootstrap. This PR therefore pulls them out into a separate test step that can be run with `./x test bootstrap-py`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While testing changes to bootstrap, I was annoyed by the fact that
./x test bootstrapspams a bunch of mysterious output to the console.That output turns out to come from
bootstrap_test.py, which runs unit tests for the Python parts of bootstrap. Those tests are (presumably) useful, but they don't add value when working on the Rust parts of bootstrap.This PR therefore pulls them out into a separate test step that can be run with
./x test bootstrap-py.